Run UI tests on the CI #10748
Merged
Run UI tests on the CI #10748
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Thanks @framebassman for your contribution
Please find my suggestions bellow, I would prefer to keep all webui relative stuff running in Docker for simplicity regarding OS and architecture.
Having the CI running the ui unit tests without docker is great and fast.
mmatur
requested changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run the UI tests on the CI
Motivation
More
- [ ] Added/updated tests- [ ] Added/updated documentationAdditional Notes