Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats race condition #1141

Merged
merged 1 commit into from Feb 22, 2017
Merged

Fix stats race condition #1141

merged 1 commit into from Feb 22, 2017

Conversation

emilevauge
Copy link
Member

Fixes #1013

Signed-off-by: Emile Vauge emile@vauge.com

@emilevauge emilevauge added this to the 1.2 milestone Feb 8, 2017
@emilevauge emilevauge mentioned this pull request Feb 8, 2017
Closed
@emilevauge
Copy link
Member Author

ping @containous/traefik

Russell-IO
Russell-IO approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@Russell-IO Russell-IO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

errm
errm approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be useful for the history if the commit message had a bit more information about what you are changing and why!

SantoDE
SantoDE approved these changes Feb 22, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilevauge
Fix stats race condition
6a56eb4 
Signed-off-by: Emile Vauge <emile@vauge.com>
@emilevauge emilevauge merged commit 727f79f into v1.2 Feb 22, 2017
@emilevauge emilevauge deleted the fix-stats-race branch April 4, 2017 21:25
@ldez ldez added the kind/bug/fix a bug fix label Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errm errm errm approved these changes

@SantoDE SantoDE SantoDE approved these changes

@Russell-IO Russell-IO Russell-IO approved these changes

Assignees
No one assigned
Labels
kind/bug/fix a bug fix
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@emilevauge @errm @SantoDE @Russell-IO @vdemeester @ldez