Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes and improvements #1173

Merged
merged 1 commit into from Feb 22, 2017
Merged

Small fixes and improvements #1173

merged 1 commit into from Feb 22, 2017

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Feb 20, 2017 •
edited

This one is a fix for #1127. I just re-done as the other one was screwed 馃棥

vdemeester
vdemeester approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃惛
/cc @containous/traefik

@emilevauge
Copy link
Member

@SantoDE same comment #1127 (comment) ;)

@emilevauge emilevauge added this to the 1.2 milestone Feb 21, 2017
@SantoDE SantoDE force-pushed the feature-rancher-improvements-1125 branch from d235fd8 to 34255bb Compare February 21, 2017 10:21
@SantoDE
Copy link
Collaborator Author

SantoDE commented Feb 21, 2017

Done @emilevauge

Russell-IO
Russell-IO approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@Russell-IO Russell-IO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

errm
errm approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emilevauge emilevauge force-pushed the feature-rancher-improvements-1125 branch from 34255bb to 253dbfa Compare February 22, 2017 15:31
emilevauge
emilevauge approved these changes Feb 22, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @SantoDE :)

@emilevauge emilevauge merged commit 28a4d65 into traefik:v1.2 Feb 22, 2017
@gaieges gaieges mentioned this pull request Feb 24, 2017
Closed
@kelchm kelchm mentioned this pull request Feb 27, 2017
Closed
3 tasks
@rawmind0 rawmind0 mentioned this pull request Feb 28, 2017
Closed
@SantoDE SantoDE deleted the feature-rancher-improvements-1125 branch September 4, 2017 13:51
@ldez ldez changed the title Small fixes and improvments Small fixes and improvements Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@errm errm errm approved these changes

@Russell-IO Russell-IO Russell-IO approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SantoDE @emilevauge @vdemeester @errm @Russell-IO @ldez