Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade k8s.io/client-go to version 2 #1178

Merged
merged 3 commits into from Apr 7, 2017
Merged

Upgrade k8s.io/client-go to version 2 #1178

merged 3 commits into from Apr 7, 2017

Conversation

errm
Copy link
Contributor

@errm errm commented Feb 22, 2017 •
edited

No description provided.

@errm errm requested a review from dtomcej February 22, 2017 09:00
@errm
Copy link
Contributor Author

errm commented Feb 22, 2017

ping @containous/traefik

vdemeester
vdemeester approved these changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

dtomcej
dtomcej approved these changes Feb 22, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@emilevauge
Copy link
Member

@errm WOW

I have copied the transitive dependencies into
glide.yaml

This will be completely impossible to maintain in the future. Is it the best way to do this??? We should at least add comments before and after those manual k8s deps.
OMG, golang deps are awful :'( :'( :'(

@timoreimann
Copy link
Contributor

@emilevauge If you are worried about dependencies becoming obsolete/unused in the future but never make their way out of the glide.yaml file again, there's the glide-cleanup plugin which takes care of that.

I know: Throwing a plugin at this problem is just another symptom for how miserable things are in the Go dependency management space.

@ekozan
Copy link

ekozan commented Feb 24, 2017 •
edited

FYI Glide install procedure will be updated -> kubernetes/client-go#127

so

package: k8s.io/client-go
   version: v2.0.0

is enouth in glide.yml

@emilevauge
Copy link
Member

Thanks for this @ekozan 😅
@errm could you update your PR ?

@errm
Copy link
Contributor Author

errm commented Mar 2, 2017

I am taking another look at this...

@ekozan I have updated glide.yaml but there are now some issues with cyclical imports...

@errm errm force-pushed the k8s-client-2 branch 4 times, most recently from cbddb59 to ff1aae5 Compare March 28, 2017 14:35
@emilevauge
Copy link
Member

@errm Should I close this one, or do you want to work on this ?

@emilevauge emilevauge closed this Apr 3, 2017
@emilevauge emilevauge reopened this Apr 3, 2017
@errm errm force-pushed the k8s-client-2 branch 6 times, most recently from affef25 to f84af19 Compare April 7, 2017 09:10
@errm
Copy link
Contributor Author

errm commented Apr 7, 2017

This should be good to go now ...

emilevauge
emilevauge approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @errm
LGTM

@emilevauge emilevauge merged commit 637c7e2 into traefik:master Apr 7, 2017
@errm errm deleted the k8s-client-2 branch April 7, 2017 18:04
@ldez ldez added this to the 1.3 milestone May 19, 2017
@ldez ldez added kind/enhancement a new or improved feature. and removed status/3-needs-merge labels May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@emilevauge emilevauge emilevauge approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@errm @emilevauge @timoreimann @ekozan @vdemeester @dtomcej @ldez