Start health checks early. #1296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
start-healthcheck-early
branch
from
1a25f87
to
51b6e5e
Compare
|
@containous/traefik PTAL. |
Do not wait a full tick cycle to execute the first health check. Additional changes: - Make request timeout configurable (for testing purposes). - Support synchronizing on health check goroutine termination through an internal wait group (for testing purposes). - Stop leaking by closing the HTTP response body. - Extend health check logging and use WARNING level for (continuously) failing health checks.
timoreimann
force-pushed
the
start-healthcheck-early
branch
from
51b6e5e
to
9cb5d9a
Compare
dtomcej
reviewed
Mar 16, 2017
| return &BackendHealthCheck{ | ||
| URL: URL, | ||
| Interval: interval, | ||
| requestTimeout: 5 * time.Second, |
There was a problem hiding this comment.
Why is a multiplier of 5 chosen here?
There was a problem hiding this comment.
That's Go's way of saying "5 seconds".
(Technically, durations are just float type aliases.)
5 secs was the default before, so I kept it but made it configurable for testing purposes.
timoreimann
commented
Mar 17, 2017
| defer hc.wg.Done() | ||
| log.Debugf("Initial healthcheck for currentBackend %s ", currentBackendID) | ||
| checkBackend(currentBackend) | ||
| ticker := time.NewTicker(currentBackend.Interval) |
There was a problem hiding this comment.
Notice that I moved the ticker up. Didn't make sense to reinitialize the ticket inside the loop.
|
I'm closing this in favor of #1319, which is the exact same branch but hosted on the containous repo; the reasoning being that I have another PR based on this branch waiting in line, which I want to push and base onto this branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not wait a full tick cycle to execute the first healh check.
Additional changes where (mostly) driven by the need for testability: