Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rancher backend left in uncommented state #1455

Merged
merged 1 commit into from Apr 18, 2017
Merged

Fix Rancher backend left in uncommented state #1455

merged 1 commit into from Apr 18, 2017

Conversation

martinbaillie
Copy link
Contributor

@martinbaillie martinbaillie commented Apr 18, 2017 •
edited

Re-commenting the Rancher backend in the sample config

Resolves #1454

@martinbaillie martinbaillie changed the title Fix Rancher backend left in uncommented state (#1454) Fix Rancher backend left in uncommented state Apr 18, 2017
timoreimann
timoreimann approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this makes total sense.

LGTM, thanks!

vdemeester
vdemeester approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 2d00758 into traefik:master Apr 18, 2017
@ldez ldez modified the milestone: 1.3 Apr 23, 2017
@timoreimann timoreimann mentioned this pull request Apr 25, 2017
Merged
@ldez ldez added kind/enhancement a new or improved feature. area/provider/rancher labels Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@timoreimann timoreimann timoreimann approved these changes

@SantoDE SantoDE Awaiting requested review from SantoDE

@emilevauge emilevauge Awaiting requested review from emilevauge

Assignees
No one assigned
Labels
area/provider/rancher kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martinbaillie @vdemeester @timoreimann @ldez