Add HTTP HEAD handling to /ping endpoint #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/api
kind/enhancement
emilevauge
requested changes
Jun 19, 2017
server/web.go
Outdated
| @@ -84,6 +84,7 @@ func (provider *WebProvider) Provide(configurationChan chan<- types.ConfigMessag | |||
|
|
|||
| // ping route | |||
| systemRouter.Methods("GET").Path(provider.Path + "ping").HandlerFunc(provider.getPingHandler) | |||
| systemRouter.Methods("HEAD").Path(provider.Path + "ping").HandlerFunc(provider.getPingHandler) | |||
There was a problem hiding this comment.
Could you instead use systemRouter.Methods("GET", "HEAD").Path(provider.Path + "ping").HandlerFunc(provider.getPingHandler) ?
There was a problem hiding this comment.
Sure @emilevauge. Done.
martinbaillie
force-pushed
the
feature/martin.baillie-ping-head-request-handler
branch
from
576f4ed
to
b04722d
Compare
timoreimann
suggested changes
Jun 20, 2017
martinbaillie
force-pushed
the
feature/martin.baillie-ping-head-request-handler
branch
from
b04722d
to
c05afe9
Compare
|
@timoreimann fixed |
emilevauge
approved these changes
Jun 20, 2017
Also updates documentation to reflect new method.
ldez
force-pushed
the
feature/martin.baillie-ping-head-request-handler
branch
from
c05afe9
to
e0e4775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1767