Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc change regarding consul SSL #1774

Merged
merged 2 commits into from Jul 18, 2017
Merged

Conversation

bitsofinfo
Copy link
Contributor

document change to clarify consul ssl, vs consul ssl client certificate security
#1718

@bitsofinfo
Copy link
Contributor Author

original #1773

@@ -143,9 +143,15 @@ To specify a Consul ACL token for Traefik, we have to set a System Environment v

If Traefik is launched into a Docker container, the variable `CONSUL_HTTP_TOKEN` can be initialized with the `-e` Docker option : `-e "CONSUL_HTTP_TOKEN=[consul-acl-token-value]"`

## TLS support
## TLS support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the white-space?

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 1.4 milestone Jul 18, 2017
document change to clarify consul ssl, vs consul ssl client certificate security
traefik#1718
removed single space
@ldez ldez merged commit 70ab34c into traefik:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants