Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove confusing go-marathon log message #1810

Merged
merged 1 commit into from
Jun 30, 2017

Commits on Jun 30, 2017

  1. remove confusing go-marathon log message

    Log message produced by go-marathon was:
    time="2017-06-28T09:08:19Z" level=debug msg="listenToSSE(): failed to
    handle event: failed to decode the event type, content: , error: EOF"
    
    The fix for this was done in the upstream project of go-marathon
    donovanhide/eventsource.
    
    Background is that Marathon periodically sends a \n over the SSE
    subscription, in order to keep the connection alive. This was parsed as
    empty event by the eventsource and published. go-marathon in turn was
    not able to do something with this empty event was producing the log
    message above. By getting rid of publishing empty events in the
    downstream library, we also get rid of this log message.
    m3co-code authored and ldez committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    a3d19f4 View commit details
    Browse the repository at this point in the history