Improve documentation. #1831
Merged
Improve documentation. #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/documentation
kind/enhancement
errm
suggested changes
Jul 7, 2017
docs/toml.md
Outdated
| # See: http://kubernetes.io/docs/user-guide/labels/#list-and-watch-filtering | ||
| # labelselector = "A and not B" | ||
| # Ingress label selector to identify Ingress objects that should be processed. | ||
| # See https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/ for details. |
There was a problem hiding this comment.
This link should be updated to https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors
docs/user-guide/kubernetes.md
Outdated
| When specifying an [ExternalName](https://kubernetes.io/docs/concepts/services-networking/service/#services-without-selectors), | ||
| Træfik will forward requests to the given host accordingly and use HTTPS when the Service port matches 443. This still requires setting up a proper port mapping on the Service from the Ingress port to the (external) Service port. | ||
|
|
||
| NB: In the future, the target Service port will likely be used to determine the protocol and specify the port to forward requests to. |
There was a problem hiding this comment.
I am not sure that "In the future" belongs in documentation... lets stick to the facts as they are now...
There was a problem hiding this comment.
WIth @errm on this one. Especially since many new users are looking at this guide.
There was a problem hiding this comment.
Makes a lot of sense -- removed.
dtomcej
suggested changes
Jul 7, 2017
docs/user-guide/kubernetes.md
Outdated
| When specifying an [ExternalName](https://kubernetes.io/docs/concepts/services-networking/service/#services-without-selectors), | ||
| Træfik will forward requests to the given host accordingly and use HTTPS when the Service port matches 443. This still requires setting up a proper port mapping on the Service from the Ingress port to the (external) Service port. | ||
|
|
||
| NB: In the future, the target Service port will likely be used to determine the protocol and specify the port to forward requests to. |
There was a problem hiding this comment.
WIth @errm on this one. Especially since many new users are looking at this guide.
timoreimann
force-pushed
the
kubernetes-clarify-labelselector
branch
from
666bc5a
to
69560b2
Compare
dtomcej
approved these changes
Jul 7, 2017
|
LGTM
|
errm
approved these changes
Jul 8, 2017
|
LGTM |
- Add details to the labelselector parameter. - Add section on ExternalNames in the guide.
ldez
force-pushed
the
kubernetes-clarify-labelselector
branch
from
1e80bca
to
3f9d1dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@containous/traefik PTAL.