Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance integration tests #1842

Merged
merged 6 commits into from Jul 10, 2017
Merged

Enhance integration tests #1842

merged 6 commits into from Jul 10, 2017

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 9, 2017

Description

  • split s.cmdTraefikWithConfigFile() to withConfigFile()
  • use withConfigFile()
  • remove unused code
  • enhance checker use
  • use s.cmdTraefik() everywhere (allow to show Traefik log output)

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Jul 9, 2017
@ldez ldez added this to the 1.4 milestone Jul 9, 2017
nmengin
nmengin approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than Checkstyle... @ldez !!! 😛
LGTM

juliens
juliens approved these changes Jul 10, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better tests, better code !

LGTM

vdemeester
vdemeester approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@ldez ldez force-pushed the refactor/integ-traefik-cmd branch from 62a8d09 to 644394d Compare July 10, 2017 12:39
@ldez ldez merged commit 2e84b1e into traefik:master Jul 10, 2017
@ldez ldez deleted the refactor/integ-traefik-cmd branch July 10, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@juliens juliens juliens approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ldez @vdemeester @juliens @nmengin