Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for dnsimple env vars. #1872

Merged
merged 3 commits into from Jul 19, 2017
Merged

Update docs for dnsimple env vars. #1872

merged 3 commits into from Jul 19, 2017

Conversation

ulm0
Copy link
Contributor

@ulm0 ulm0 commented Jul 18, 2017

Description

Yesterday I followed the docs (https://docs.traefik.io/toml/#acme-lets-encrypt-configuration) to set traefik with dnsimple as dns provider in order to get Let's Encrypt certs with txt dns challenge.

Thing is traefik says I need to set some env vars for the container to use and setup dnsimple (DNSIMPLE_EMAIL and DNSIMPLE_API_KEY in this case), I set them but wasn't able to use dnsimple (the container exited), found out in the logs it exited because of something related to an OAuth key that wasn't found ('cause it was not set), after searching for the library traefik use for this (https://github.com/xenolf/lego/blob/master/providers/dns/dnsimple/dnsimple.go#L25) I figured out I needed to set a different env var instead of DNSIMPLE_API_KEY (DNSIMPLE_OAUTH_TOKEN) so i did, now it's working without problems.

So i opened this PR in order to update the docs.

PS. Sorry, bad commit description, it's midnight here and i'm kinda sleepy.

@ldez
Copy link
Member

ldez commented Jul 18, 2017

@klud1 Thanks for the contribution 👍

Could you also change this file: https://github.com/containous/traefik/blob/master/traefik.sample.toml#L157

@ulm0
Copy link
Contributor Author

ulm0 commented Jul 18, 2017

@ldez sure! updated that file as well.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

LGTM!

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez modified the milestone: 1.4 Jul 19, 2017
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

@ldez ldez merged commit 16609cd into traefik:master Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants