Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default frontend priority of zero. #1906

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Use default frontend priority of zero. #1906

merged 1 commit into from
Aug 18, 2017

Commits on Aug 18, 2017

  1. [kubernetes] Use default frontend priority of zero. 

    Conventionally all providers should return a priority of zero if no
override is given. The server package will then compute the priority
based on the specified rules (i.e., path and host components).

The Kubernetes provider diverges and returns the path length as
default value explicitly. This change removes the custom behavior.

As a side refactoring, we change the tests to stop comparing JSON values
which are prone to subtle but non-visible differences (namely, nil
and empty properties are not reflected). Instead, we use assert.Equal
which also does a better job at showing a readable diff.
    @timoreimann @traefiker
    timoreimann authored and traefiker committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    169343d View commit details
    Browse the repository at this point in the history