Enable loadbalancer.sticky for ECS #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/provider/ecs
contributor/waiting-for-corrections
kind/enhancement
|
Could you fix the build?
|
|
This PR is the implementation for feature requested on #1522 |
ldez
requested changes
Aug 8, 2017
provider/ecs/ecs.go
Outdated
|
|
||
| func (p *Provider) LoadBalancerMethod(instances []ecsInstance) string { | ||
| for instances != nil && len(instances) > 0 { | ||
| if label := instances[0].label(types.LabelBackendLoadbalancerMethod); label != "" { |
provider/ecs/ecs.go
Outdated
| @@ -420,6 +432,24 @@ func (p *Provider) getFrontendRule(i ecsInstance) string { | |||
| return "Host:" + strings.ToLower(strings.Replace(i.Name, "_", "-", -1)) + "." + p.Domain | |||
| } | |||
|
|
|||
| func (p *Provider) LoadBalancerSticky(instances []ecsInstance) string { | |||
| for instances != nil && len(instances) > 0 { | |||
| if label := instances[0].label(types.LabelBackendLoadbalancerSticky); label != "" { | |||
provider/ecs/ecs.go
Outdated
| @@ -420,6 +432,24 @@ func (p *Provider) getFrontendRule(i ecsInstance) string { | |||
| return "Host:" + strings.ToLower(strings.Replace(i.Name, "_", "-", -1)) + "." + p.Domain | |||
| } | |||
|
|
|||
| func (p *Provider) LoadBalancerSticky(instances []ecsInstance) string { | |||
| for instances != nil && len(instances) > 0 { | |||
provider/ecs/ecs.go
Outdated
| } | ||
|
|
||
| func (p *Provider) LoadBalancerMethod(instances []ecsInstance) string { | ||
| for instances != nil && len(instances) > 0 { |
provider/ecs/ecs.go
Outdated
| @@ -420,6 +432,24 @@ func (p *Provider) getFrontendRule(i ecsInstance) string { | |||
| return "Host:" + strings.ToLower(strings.Replace(i.Name, "_", "-", -1)) + "." + p.Domain | |||
| } | |||
|
|
|||
| func (p *Provider) getLoadBalancerSticky(instances []ecsInstance) string { | |||
| for instances != nil && len(instances) > 0 { | |||
| if label := instances[0].label(types.LabelBackendLoadbalancerSticky); label != "" { | |||
provider/ecs/ecs.go
Outdated
|
|
||
| func (p *Provider) getLoadBalancerMethod(instances []ecsInstance) string { | ||
| for instances != nil && len(instances) > 0 { | ||
| if label := instances[0].label(types.LabelBackendLoadbalancerMethod); label != "" { |
provider/ecs/ecs.go
Outdated
| @@ -420,6 +432,24 @@ func (p *Provider) getFrontendRule(i ecsInstance) string { | |||
| return "Host:" + strings.ToLower(strings.Replace(i.Name, "_", "-", -1)) + "." + p.Domain | |||
| } | |||
|
|
|||
| func (p *Provider) getLoadBalancerSticky(instances []ecsInstance) string { | |||
| for instances != nil && len(instances) > 0 { | |||
There was a problem hiding this comment.
instances != nil is unnecessary.
func ExampleEmptySlice() {
var foo []string
fii := bar()
fmt.Println(foo, fii)
// output: [] []
}
func bar() []string{
return nil
}
provider/ecs/ecs.go
Outdated
| } | ||
|
|
||
| func (p *Provider) getLoadBalancerMethod(instances []ecsInstance) string { | ||
| for instances != nil && len(instances) > 0 { |
There was a problem hiding this comment.
instances != nil is unnecessary.
func ExampleEmptySlice() {
var foo []string
fii := bar()
fmt.Println(foo, fii)
// output: [] []
}
func bar() []string{
return nil
}There was a problem hiding this comment.
Thanks for the go course. I will fix that asap
provider/ecs/ecs.go
Outdated
| @@ -189,10 +191,20 @@ func (p *Provider) loadECSConfig(ctx context.Context, client *awsClient) (*types | |||
|
|
|||
| instances = fun.Filter(p.filterInstance, instances).([]ecsInstance) | |||
|
|
|||
| services := make(map[string][]ecsInstance) | |||
|
|
|||
| for _, i := range instances { | |||
There was a problem hiding this comment.
could you rename i to instance ?
I know it's already use but I think i is an ambiguous name in a for.
ldez
added
contributor/waiting-for-corrections
and removed
contributor/waiting-for-corrections
labels
emilevauge
approved these changes
Aug 24, 2017
traefiker
force-pushed
the
session-stickiness-ecs
branch
from
7fc5ac8
to
bc19311
Compare
…ancerSticky and getLoadBalancerMethod function
traefiker
force-pushed
the
session-stickiness-ecs
branch
from
bc19311
to
b61a639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to add support of sticky session for ECS.
Low balancer configuration will be always present with default values:
traefik.backend.loadbalancer.method=wrrtraefik.backend.loadbalancer.sticky=falseTo override these values you just to add labels
Fixes #1522