Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the Cookie Path explicitly to root #1950

Merged
merged 2 commits into from Aug 13, 2017
Merged

Conversation

marcopaga
Copy link
Contributor

@marcopaga marcopaga commented Aug 12, 2017

Created the PR to get the changes from oxy to set the sticky session cookie to "/".

Fixes #1744

@timoreimann
Copy link
Contributor

You have seemingly forgotten to update the glide hash in the lock file. That's why the CI is red.

@ldez ldez changed the title 1744 Setting the Cookie Path explicitly to root via oxy Setting the Cookie Path explicitly to root Aug 12, 2017
@traefik traefik deleted a comment from marcopaga Aug 12, 2017
@ldez ldez added this to the 1.4 milestone Aug 12, 2017
@marcopaga
Copy link
Contributor Author

Too bad. I changed the hash in the glide.lock and glide.yml. Not sure what went wrong.
I'm on vacation without a dev environment. I can check it when I'm back.

@ldez
Copy link
Member

ldez commented Aug 12, 2017

@marcopaga I have fixed the problem.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcopaga
Copy link
Contributor Author

@ldez Thank you very much!

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants