Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract metrics to own package and refactor implementations #1968

Merged
merged 9 commits into from Aug 23, 2017
Merged

Extract metrics to own package and refactor implementations #1968

merged 9 commits into from Aug 23, 2017

Commits on Aug 23, 2017

  1. rename global var metrics to stats 

    in order to avoid a name clash for the soon to come metrics package.
    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    dd166e5 View commit details
    Browse the repository at this point in the history

  2. extract metrics implementation to own package 

    This commit is just refactoring and should provide the same
functionality as before. It extracts the metrics implementation into its
own package and makes metrics therefore extendable to be used outside of
the middleware package in the future.

Another design goal is to simplify and align the initialisation of the Metrics
implementations. Each Metric provider should only be initialised once
and reused when configuration reloads happen. This commit accomplishes
this.
    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    0406958 View commit details
    Browse the repository at this point in the history

  3. fix import order

    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    ea4fef4 View commit details
    Browse the repository at this point in the history

  4. implement review feedback

    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    047d853 View commit details
    Browse the repository at this point in the history

  5. fix formatting

    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    310ac8d View commit details
    Browse the repository at this point in the history

  6. implement review feedback

    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    baba69a View commit details
    Browse the repository at this point in the history

  7. remove obosolete and wrong comment

    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    9a385f4 View commit details
    Browse the repository at this point in the history

  8. extract metricsEnabled to own Registry method 

    in order to have less state on the server struct.
    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    9ee02d6 View commit details
    Browse the repository at this point in the history

  9. rename field isEnabled to enabled

    @mjeri @traefiker
    mjeri authored and traefiker committed Aug 23, 2017
    Copy the full SHA
    6a4221b View commit details
    Browse the repository at this point in the history