-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request accepting grace period delaying graceful shutdown. #1971
Merged
traefiker
merged 9 commits into
traefik:master
from
timoreimann:add-request-accepting-grace-period
Sep 26, 2017
Merged
Add request accepting grace period delaying graceful shutdown. #1971
traefiker
merged 9 commits into
traefik:master
from
timoreimann:add-request-accepting-grace-period
Sep 26, 2017
Commits on Sep 25, 2017
-
Add request accepting grace period delaying graceful shutdown.
The new grace period defines how long Traefik should continue accepting requests prior to shutting down all connection listeners. It preceeds the existing (HTTP shutdown) grace period and allows for a full-circle graceful termination by expecting downstream load-balancers to take Traefik out of rotation in time, without the need for rather complex and external request draining procedures. Immediate beneficiaries are providers such as Kubernetes and Marathon which expect in-cluster applications to exhibit the described termination behavior.
Configuration menu - View commit details
-
Copy full SHA for 2901e69 - Browse repository at this point
Copy the full SHA 2901e69View commit details -
Rename variable req{Term,Accept}GraceTimeout.
Former name stems from a previous (never published) naming schema.
Configuration menu - View commit details
-
Copy full SHA for b8c8d3d - Browse repository at this point
Copy the full SHA b8c8d3dView commit details -
Remove restriction on syscall.SIGTERM.
Doesn't really make sense since we shut down the server for SIGINT gracefully as well.
Configuration menu - View commit details
-
Copy full SHA for 50c6e1b - Browse repository at this point
Copy the full SHA 50c6e1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 121d782 - Browse repository at this point
Copy the full SHA 121d782View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a102f - Browse repository at this point
Copy the full SHA a3a102fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e74537b - Browse repository at this point
Copy the full SHA e74537bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a2b814 - Browse repository at this point
Copy the full SHA 9a2b814View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f84490 - Browse repository at this point
Copy the full SHA 8f84490View commit details
Commits on Sep 26, 2017
-
Configuration menu - View commit details
-
Copy full SHA for dd1a108 - Browse repository at this point
Copy the full SHA dd1a108View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.