Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more visibility to docker stack deploy label issue #1984

Merged
merged 3 commits into from Aug 22, 2017
Merged

Add more visibility to docker stack deploy label issue #1984

merged 3 commits into from Aug 22, 2017

Conversation

jmaitrehenry
Copy link
Contributor

Fix #1983

@jmaitrehenry jmaitrehenry requested a review from a team as a code owner August 21, 2017 18:27
@ldez ldez added this to the 1.4 milestone Aug 21, 2017
vdemeester
vdemeester approved these changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

ldez
ldez approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 05665f4 into traefik:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmaitrehenry @vdemeester @ldez @nmengin @traefiker