Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IAM policy sid. #2066

Merged
merged 2 commits into from Sep 7, 2017
Merged

Fix IAM policy sid. #2066

merged 2 commits into from Sep 7, 2017

Conversation

charlieoleary
Copy link
Contributor

Description

The required IAM policy uses spaces in the Sid field, but this is not allowed by IAM. As a result, attempting to create this policy results in a validation error. The fix is simply to remove the spaces from the Sid.

@ldez
Copy link
Member

ldez commented Sep 5, 2017

Could change your PR to point to 1.4 branch?

Ask me if you need help.

@charlieoleary charlieoleary changed the base branch from master to v1.4 September 5, 2017 22:33
@charlieoleary
Copy link
Contributor Author

@ldez Updated!

@ldez ldez added this to the 1.4 milestone Sep 5, 2017
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants