Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guide section on production advice, esp. CPU. #2113

Merged
merged 2 commits into from Sep 12, 2017
Merged

Add guide section on production advice, esp. CPU. #2113

merged 2 commits into from Sep 12, 2017

Conversation

timoreimann
Copy link
Contributor

I also removed all existing resource specifications just to make sure people aren't taken them at face value.

/cc @kachkaev

Fixes #1908.

@timoreimann timoreimann added area/documentation bot/light-review decreases the number of required LGTM from 3 to 1. kind/enhancement a new or improved feature. labels Sep 12, 2017
@timoreimann timoreimann requested a review from a team September 12, 2017 16:48
@traefiker traefiker added this to the 1.4 milestone Sep 12, 2017
@kachkaev kachkaev mentioned this pull request Sep 12, 2017
Closed
kachkaev
kachkaev approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@traefiker traefiker merged commit 5305a16 into traefik:v1.4 Sep 12, 2017
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Sep 12, 2017
@emilevauge
Copy link
Member

@timoreimann the bot/light-review is not intended to be used in this use case:

bot/light-review can be used to decrease required LGTM from 3 to 1 when:

- vendor updates from previously reviewed PRs
- merges branches into master
- prepare release

I understand this PR is a lightweight documentation review, but we still want to stick with the standard process :)

@timoreimann
Copy link
Contributor Author

timoreimann commented Sep 13, 2017 •
edited

sorry @emilevauge, that was actually a mistake -- I didn't even realize I had chosen that label by accident until you commented. My bad!

How should we go about this one? Revert and reopen another PR? Or continue commenting here and I do a follow-up PR for anything outstanding?

@emilevauge
Copy link
Member

hey @timoreimann, no problem :) no revert on this pr, great addition 👌

@timoreimann timoreimann deleted the k8s-add-prod-advice-guide-section branch September 13, 2017 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachkaev kachkaev kachkaev approved these changes

@ldez ldez ldez approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timoreimann @emilevauge @kachkaev @ldez @traefiker