Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Traefik logs in integration tests #2114

Merged
merged 5 commits into from Sep 13, 2017
Merged

Display Traefik logs in integration tests #2114

merged 5 commits into from Sep 13, 2017

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 12, 2017

Description

Display Traefik logs in integration test if tests failed.

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Sep 12, 2017
@ldez ldez added this to the 1.4 milestone Sep 12, 2017
@ldez ldez requested a review from a team as a code owner September 12, 2017 19:23
timoreimann
timoreimann approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏

nmengin
nmengin approved these changes Sep 13, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bdeb7bf into traefik:v1.4 Sep 13, 2017
@ldez ldez deleted the refactor/integration-test-cmd-logs branch September 14, 2017 09:56
@ldez ldez changed the title Display Traefik logs in integration test Display Traefik logs in integration tests Sep 14, 2017
@timoreimann timoreimann mentioned this pull request Sep 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@timoreimann timoreimann timoreimann approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @juliens @timoreimann @emilevauge @nmengin @traefiker