Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul catalog failed to remove service #2157

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Consul catalog failed to remove service #2157

merged 1 commit into from
Sep 29, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 21, 2017 •
edited by ldez

We need to reset the current state between two call to GetServices

Fixes #2155

@juliens juliens added this to the 1.4 milestone Sep 21, 2017
nmengin
nmengin approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

ldez
ldez approved these changes Sep 21, 2017
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur reviewed Sep 26, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 64c52a6 into traefik:v1.4 Sep 29, 2017
@traefiker traefiker mentioned this pull request Sep 29, 2017
Closed
@ldez ldez changed the title Consul catalog remove service failed Consul catalog failed to remove service Oct 1, 2017
@juliens juliens deleted the consul-remove branch January 25, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur left review comments

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/consulcatalog kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juliens @mmatur @ldez @emilevauge @nmengin @traefiker