dumpcerts.sh: fixed sed, extracted domain keys #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
added
status/3-needs-merge
and removed
status/2-needs-review
status/3-needs-merge
labels
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I beefed up the script to extract certs and private keys from acme.json, thought I'd share. The sed script needed a bit of tweaking (
-Eswitch,>>instead of>), and I added an openssl check after the sed script to double-check the generated script is correct.Also, the certificate files were being saved as
*.peminstead of*.crt, and the domain private keys weren't being extracted. I corrected that.Finally, I cannot for the life of me get the
opensslscript to work (openssl rsa -informetc.). If someone can confirm it works for them, I'll just write it off to me being dumb.