Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be certain to clear our marshalled representation before reloading it #2165

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

gozer
Copy link
Contributor

@gozer gozer commented Sep 22, 2017

Clear Object first, as mapstructure's decoder doesn't have ZeroFields set to true for merging purposes

Fixes #2153

Clear Object first, as mapstructure's decoder doesn't have ZeroFields set to true for merging purposes

Fixes traefik#2153
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants