Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gRPC example #2191

Merged
merged 4 commits into from Oct 2, 2017
Merged

Update gRPC example #2191

merged 4 commits into from Oct 2, 2017

Conversation

jsenon
Copy link
Contributor

@jsenon jsenon commented Sep 30, 2017

Description

ldez
ldez requested changes Sep 30, 2017
View reviewed changes
docs/user-guide/grpc.md Outdated
@@ -92,14 +92,24 @@ So we modify the "gRPC server example" to use our own self-signed certificate:
```go
// ...

import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this block (imports) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with your modification we need to add some import

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

docs/user-guide/grpc.md Outdated
@@ -121,8 +133,24 @@ Next we will modify gRPC Client to use our Træfik self-signed certificate:
```go
// ...

import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this block (imports) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to add import with your modification

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

docs/user-guide/grpc.md Outdated

)

const (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could remove those constants and restore previous code?
You can create local variable if you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original grpc-go use const why don't use it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is for illustrative purposes only. We want this section to be small.

docs/user-guide/grpc.md Outdated
err := s.Serve(lis)

// s := grpc.NewServer()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to comment original code from grpc-go

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

@ldez ldez changed the title Modification of greeter_server, Modification of greeter_client Update gRPC example Sep 30, 2017
ldez
ldez requested changes Sep 30, 2017
View reviewed changes
docs/user-guide/grpc.md Outdated
@@ -92,14 +92,20 @@ So we modify the "gRPC server example" to use our own self-signed certificate:
```go
// ...

"crypto/tls"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove those lines.

docs/user-guide/grpc.md Outdated

// ...

"crypto/x509"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove those lines.

juliens
juliens approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 📖

@ldez ldez changed the base branch from master to v1.4 October 2, 2017 09:13
@ldez ldez added this to the 1.4 milestone Oct 2, 2017
@traefiker traefiker merged commit ec5976b into traefik:v1.4 Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/documentation size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsenon @juliens @ldez @nmengin @traefiker