Stickiness cookie name. #2251
Merged
Stickiness cookie name. #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
timoreimann
approved these changes
Oct 11, 2017
emilevauge
reviewed
Oct 12, 2017
There was a problem hiding this comment.
Reading this PR and #2232 again, I think I'm missing something on few things:
hasStickinessLabelimplementations differ quite a lot between providers. Why?- in some providers, the cookie name can be generated, and in some others, can just be set by labels (
getStickinessCookieName) - only few providers seems to be tested on this
Again, I may be wrong or missed something!
|
traefiker
approved these changes
Oct 12, 2017
traefiker
force-pushed
the
fix/template-cookie-name
branch
from
e1d07c3
to
a528776
Compare
ldez
force-pushed
the
fix/template-cookie-name
branch
from
a528776
to
7c9b68d
Compare
|
Is this on docker yet? |
|
@MichaelErmer @gabrielfsousa could you try |
|
@ldez it "works" (starts) however it doesnt enable stickiness using these labels: nor backwards compatible: |
|
Need stickiness and cookieName working with Docker Swarm backend as well, please. Thank you. |
|
oh yes, im using docker swarm maybe thats the issue... |
|
please look #2266 馃槈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2232
Fixes #2249