Missing Backend key in configuration when application has no tasks #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #1689. |
|
@dtomcej you probably want to have a look at this too. |
|
This directly addresses the cause of the issue. I am totally on board with this. 👍 This is not a band-aid approach :D |
aantono
force-pushed
the
marathon-empty-task-fix
branch
from
2806532
to
b8daf41
Compare
ldez
added
status/2-needs-review
kind/bug/fix
|
@aantono Could you change the base branch to 1.4 and rebase? Thanks. |
aantono
force-pushed
the
marathon-empty-task-fix
branch
from
b8daf41
to
277e14a
Compare
aantono
force-pushed
the
marathon-empty-task-fix
branch
from
277e14a
to
5033b63
Compare
nmengin
approved these changes
Oct 31, 2017
|
I'll give this one a quick whirl just to be sure some time tonight. |
timoreimann
approved these changes
Oct 31, 2017
timoreimann
added
status/3-needs-merge
and removed
bot/no-merge
status/2-needs-review
labels
|
Should I rebase against |
…are available for an application
aantono
force-pushed
the
marathon-empty-task-fix
branch
from
5033b63
to
5cf6ca5
Compare
|
@aantono shouldn't be necessary: Traefiker (our bot) can handle this by now. If not, it'll complain. :) |
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue of missing Backend key in configuration when no tasks are available for an application
If Marathon application has no valid tasks in existence (either because the tasks are in bad state or they are in the process of being started or shut down), the generated configuration is completely missing the Backend key entry for the bound Frontend, resulting in a 404 response from Traefik instead of the expected 503.