Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lightMarathonClient. #2383

Merged
merged 1 commit into from Nov 9, 2017
Merged

Remove unused lightMarathonClient. #2383

merged 1 commit into from Nov 9, 2017

Conversation

timoreimann
Copy link
Contributor

This became obsolete at a point when we refactored/simplified the Marathon tests.

@timoreimann timoreimann requested a review from a team as a code owner November 9, 2017 10:48
ldez
ldez approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

juliens
juliens approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliens juliens added this to the 1.5 milestone Nov 9, 2017
@timoreimann @traefiker
[marathon] Remove unused lightMarathonClient.
b03cd71 
This became obsolete at a point when we refactored/simplified the
Marathon tests.
@traefiker traefiker force-pushed the marathon-remove-unsued-light-client branch from 0db15b8 to b03cd71 Compare November 9, 2017 11:18
@traefiker traefiker merged commit 384488a into traefik:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/provider/marathon kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timoreimann @juliens @mmatur @ldez @emilevauge @traefiker