Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude GRPC from compress #2391

Merged
merged 1 commit into from Nov 10, 2017
Merged

Exclude GRPC from compress #2391

merged 1 commit into from Nov 10, 2017

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 10, 2017 •
edited by juliens

What does this PR do?

Exclude GRPC from compress

Motivation

GRPC provide an internal compression system.

More

  • Added/updated tests

@traefiker traefiker added this to the 1.4 milestone Nov 10, 2017
juliens
juliens approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker merged commit 5c119fe into traefik:v1.4 Nov 10, 2017
@ldez ldez deleted the fix/compress-grpc branch November 10, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker