Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants from http package. #2425

Merged
merged 1 commit into from Nov 20, 2017
Merged

Use constants from http package. #2425

merged 1 commit into from Nov 20, 2017

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 18, 2017

What does this PR do?

use http.Status* and http.Method*

Motivation

to be homogeneous

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Nov 18, 2017
@ldez ldez added this to the 1.5 milestone Nov 18, 2017
timoreimann
timoreimann approved these changes Nov 18, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nmengin
nmengin approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

juliens
juliens approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 05a9350 into traefik:master Nov 20, 2017
@ldez ldez deleted the refactor/http-constants branch November 20, 2017 10:44
@ldez ldez changed the title Use contants from http package. Use constants from http package. Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@juliens juliens juliens approved these changes

@timoreimann timoreimann timoreimann approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/logs area/middleware area/provider/consul area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @vdemeester @juliens @timoreimann @nmengin @traefiker