Remove obsolete links in k8s docs #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
area/documentation
kind/bug/fix
mjeri
force-pushed
the
fix-link-in-k8s-docs
branch
from
07299a0
to
37c70d7
Compare
|
@marco-jantke looking at the docs page, I get the feeling that the two example links are misplaced: I'm thinking that it might be better to just drop the whole paragraph. We already have a pointer to our Kubernetes guide at the very top of the Kubernetes configuration page. WDYT? |
mjeri
force-pushed
the
fix-link-in-k8s-docs
branch
from
37c70d7
to
934b06d
Compare
mjeri
force-pushed
the
fix-link-in-k8s-docs
branch
from
934b06d
to
0257b8f
Compare
|
Makes definitely sense. Updated the PR description and title. |
nmengin
added
status/3-needs-merge
size/S
and removed
area/provider/k8s/ingress
size/S
status/2-needs-review
labels
|
Merge conflicts need to be resolved. |
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: as suggested by @timoreimann I removed the links completely.