Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Fabric 'expose' as boolean. #2476

Merged
merged 1 commit into from Nov 28, 2017
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 28, 2017

What does this PR do?

'expose' as boolean.

Motivation

Fix a bug.

Additional Notes

Related containous/traefik-extra-service-fabric#5

@ldez ldez added area/provider/servicefabric bot/light-review decreases the number of required LGTM from 3 to 1. kind/bug/fix a bug fix status/2-needs-review labels Nov 28, 2017
@ldez ldez added this to the 1.5 milestone Nov 28, 2017
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ad07a6a into traefik:master Nov 28, 2017
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Nov 28, 2017
@ldez ldez deleted the fix/sf-expose branch November 28, 2017 12:35
@ldez ldez changed the title fix: Service Fabric 'expose' as boolean. Service Fabric 'expose' as boolean. Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants