Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote template strings #2496

Merged
merged 1 commit into from Nov 30, 2017
Merged

Quote template strings #2496

merged 1 commit into from Nov 30, 2017

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Nov 30, 2017 •
edited by ldez

What does this PR do?

This PR is a bugfix to correct unquoted strings on the Docker Template.

Motivation

Fixes #2493

@traefiker traefiker added this to the 1.5 milestone Nov 30, 2017
@dtomcej dtomcej requested a review from a team November 30, 2017 03:31
nmengin
nmengin approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

mmatur
mmatur approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

juliens
juliens approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 313357a into traefik:v1.5 Nov 30, 2017
@traefiker traefiker mentioned this pull request Nov 30, 2017
Closed
@mmatur mmatur changed the title quote template strings Quote template strings Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtomcej @juliens @mmatur @nmengin @ldez @traefiker