Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pointer of error pages #2607

Merged
merged 1 commit into from Dec 21, 2017
Merged

Use pointer of error pages #2607

merged 1 commit into from Dec 21, 2017

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 21, 2017

What does this PR do?

Use pointer of error pages

Motivation

Use pointer of error pages

More

  • Added/updated tests

@ldez ldez added this to the 1.6 milestone Dec 21, 2017
@ldez ldez requested a review from a team as a code owner December 21, 2017 10:09
nmengin
nmengin approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* LGTM *

juliens
juliens approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 59549d5 into traefik:master Dec 21, 2017
@ldez ldez deleted the refactor/error-pages-pointer branch December 21, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/middleware area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker