Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenization of the providers (part 1): KV #2616

Merged
merged 3 commits into from Jan 2, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 23, 2017

What does this PR do?

Similar to #2518 but for KV (BoldDB, Consul, Etcd, ZK)

  • add more tests
  • enhance template readability and maintainability
  • split provide and build configuration

Motivation

Make it easier to add new configuration parameter.

More

  • Added/updated tests

Additional Notes

Homogenization of the providers [part1]

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Dec 23, 2017
@ldez ldez added this to the 1.6 milestone Dec 23, 2017
@ldez ldez force-pushed the refactor/template-kv branch 11 times, most recently from ba376ae to e4f4c9b Compare December 25, 2017 17:58
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@ldez ldez force-pushed the refactor/template-kv branch 8 times, most recently from e077854 to 45fa66d Compare December 31, 2017 22:02
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants