Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s guide: Leave note about assumed DaemonSet usage. #2634

Merged

Conversation

timoreimann
Copy link
Contributor

What does this PR do?

Leave a note about assumed DaemonSet usage in the Kubernetes guide.

Motivation

Make sure users are aware of the DaemonSet/Deployment distinction (and the implications as to the reachable port) as they follow the guide.

Fixes #2633.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 📖

@traefiker traefiker force-pushed the kubernetes-guide-note-on-daemonset-usage branch from de7d1f7 to 0aa82fd Compare January 3, 2018 07:56
@traefiker traefiker merged commit 01e17b6 into traefik:v1.5 Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants