Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homogenization of templates: KV #2661

Merged
merged 2 commits into from Jan 9, 2018
Merged

homogenization of templates: KV #2661

merged 2 commits into from Jan 9, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 5, 2018

What does this PR do?

Simplify template and use typed function.

Motivation

Homogenization of the providers [part3]: try to have a shared template

More

  • Added/updated tests

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Jan 5, 2018
@ldez ldez added this to the 1.6 milestone Jan 5, 2018
@ldez ldez mentioned this pull request Jan 7, 2018
Merged
1 task
nmengin
nmengin approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

juliens
juliens approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b60edd9 into traefik:master Jan 9, 2018
@ldez ldez deleted the refactor/kv-template branch January 9, 2018 19:00
@ldez ldez mentioned this pull request Jan 30, 2018
Closed
8 tasks
@ldez ldez mentioned this pull request Feb 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/boltdb area/provider/consul area/provider/etcd area/provider/kv area/provider/zk kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker