Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document rewrite-target annotation. #2676

Merged
merged 1 commit into from Jan 9, 2018
Merged

Document rewrite-target annotation. #2676

merged 1 commit into from Jan 9, 2018

Conversation

timoreimann
Copy link
Contributor

What does this PR do?

Document the rewrite-target annotation.

@timoreimann timoreimann requested a review from a team as a code owner January 8, 2018 17:17
@traefiker traefiker added this to the 1.5 milestone Jan 8, 2018
@timoreimann timoreimann force-pushed the kubernetes/document-rewrite-target-annotation branch from 53c3037 to 6d47d3d Compare January 8, 2018 17:19
ldez
ldez approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez mentioned this pull request Jan 8, 2018
Merged
nmengin
nmengin approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the kubernetes/document-rewrite-target-annotation branch from 6d47d3d to 7a83fb1 Compare January 9, 2018 10:24
@ldez ldez removed the bot/no-merge label Jan 9, 2018
@traefiker traefiker force-pushed the kubernetes/document-rewrite-target-annotation branch from 7a83fb1 to 3858cd2 Compare January 9, 2018 10:40
@traefiker traefiker merged commit e74a20d into traefik:v1.5 Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timoreimann @mmatur @ldez @nmengin @traefiker