Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad access log #2682

Merged
merged 5 commits into from Jan 11, 2018
Merged

Fix bad access log #2682

merged 5 commits into from Jan 11, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jan 9, 2018 •
edited

What does this PR do?

This PR fix two issues:

  • bad access log when Træfik throw an error
  • missing quotes on referrer and user-agent fields

Motivation

Fixes #2649 #2565

More

  • Added/updated tests

@mmatur mmatur added this to the 1.6 milestone Jan 9, 2018
@mmatur mmatur force-pushed the improve-access-log branch 4 times, most recently from dbaaef7 to 6ccd255 Compare January 9, 2018 19:34
@mmatur mmatur force-pushed the improve-access-log branch 3 times, most recently from bb80e80 to 1683798 Compare January 10, 2018 15:09
nmengin
nmengin approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 🗞️

juliens
juliens requested changes Jan 10, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

integration/fixtures/consul/simple.toml469785378 Outdated
@@ -0,0 +1,16 @@
defaultEntryPoints = ["http"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this file ?

integration/fixtures/traefik_log_config.toml Outdated
@@ -11,3 +15,11 @@ checkNewVersion = false
[entryPoints]
[entryPoints.http]
address = ":8000"

[web]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[web] is deprecated

integration/fixtures/access_log_config.toml Outdated
[entryPoints.httpFrontendAuth]
address = ":8006"
[entryPoints.httpRateLimit]
address = ":8007"

checkNewVersion = false

################################################################
# Web configuration backend
################################################################
[web]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[web] is deprecated

ldez
ldez approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 709d508 into traefik:master Jan 11, 2018
@mmatur mmatur deleted the improve-access-log branch March 21, 2018 17:48
@sayden sayden mentioned this pull request Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/logs area/middleware kind/bug/fix a bug fix size/L
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Missing quotes arround the Referer field in access logs
5 participants
@mmatur @juliens @ldez @nmengin @traefiker