New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify DEBUG messages to get ACME certificates #2685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
acme/challengeProvider.go
Outdated
@@ -31,7 +31,7 @@ type challengeProvider struct { | |||
} | |||
|
|||
func (c *challengeProvider) getCertificate(domain string) (cert *tls.Certificate, exists bool) { | |||
log.Debugf("Challenge GetCertificate %s", domain) | |||
log.Debugf("Look for existing ACME challenge for %s...", domain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Look for/Looking for an/
acme/acme.go
Outdated
@@ -351,7 +351,7 @@ func (a *ACME) getCertificate(clientHello *tls.ClientHelloInfo) (*tls.Certificat | |||
} | |||
return a.loadCertificateOnDemand(clientHello) | |||
} | |||
log.Debugf("ACME got nothing %s", domain) | |||
log.Debugf("None certificate found or generated for %s", domain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/None certificate found/No certificate found/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR improve the ACME DEBUG messages.
Motivation
Fix #2664