Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect problem on dashboard + docs/tests on [web] #2686

Merged
merged 1 commit into from Jan 11, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 10, 2018

What does this PR do?

Fix a problem with the dashboard redirect
Fix error in documentation + integration tests

Motivation

Answer how to handle the deprecation of --web.path
Fix the doc with deprecated

Related #1233

Closes #2686


# Set the root path for webui and API
#
# Optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add a "Deprecated" here.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants