Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in anonymous usage log message. #2711

Merged
merged 1 commit into from Jan 17, 2018
Merged

Fix typo in anonymous usage log message. #2711

merged 1 commit into from Jan 17, 2018

Conversation

Yggdrasil
Copy link
Contributor

Matches link to docs in log message to actual URL.

@ldez ldez added this to the 1.5 milestone Jan 16, 2018
ldez
ldez approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez
Copy link
Member

ldez commented Jan 16, 2018

@Yggdrasil could you rebase on 1.5 and change the PR base branch to 1.5.

mmatur
mmatur approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez mentioned this pull request Jan 17, 2018
Closed
juliens
juliens reviewed Jan 17, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yggdrasil @ldez
Fix typo in anonymous usage docs URL.
4e36f95 
Matches link in log message to actual URL.
@ldez ldez changed the base branch from master to v1.5 January 17, 2018 11:04
@traefiker traefiker merged commit adfa3f7 into traefik:v1.5 Jan 17, 2018
@Yggdrasil
Copy link
Contributor Author

@ldez Thanks for rebasing for me.

@Yggdrasil Yggdrasil deleted the patch-1 branch January 18, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Yggdrasil @ldez @juliens @mmatur @traefiker