Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing configuration for jaeger reporter #2720

Merged
merged 1 commit into from Jan 18, 2018
Merged

Fix missing configuration for jaeger reporter #2720

merged 1 commit into from Jan 18, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jan 17, 2018

What does this PR do?

This PR fix a missing configuration for Jaeger.
Add property LocalAgentHostPort to allow user to configure host and port where Jaeger reporter will send span

More

  • Added/updated documentation

Additional Notes

The configuration will be like that now :

[tracing]
    backend = "jaeger"
    servicename = "powpow"
    [tracing.jaeger]
    SamplingType = "const"
    LocalAgentHostPort = "jaeger:6832"
    SamplingServerURL = "http://jaeger:5778/sampling"
    SamplingParam = 1.0

@mmatur mmatur added this to the 1.6 milestone Jan 17, 2018
ldez
ldez approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adammeghji
Copy link

awesome thanks for the fix! 🙌

juliens
juliens approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f1f2e1b into traefik:master Jan 18, 2018
@mmatur mmatur deleted the fix/tracing-jaeger-config branch March 21, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/middleware/tracing kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmatur @adammeghji @juliens @ldez @nmengin @traefiker