Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary mutex usage in health checks #2726

Merged
merged 1 commit into from Jan 22, 2018
Merged

Remove unnecessary mutex usage in health checks #2726

merged 1 commit into from Jan 22, 2018

Conversation

m3co-code
Copy link
Contributor

@m3co-code m3co-code commented Jan 19, 2018 •
edited

This mutex was introduced in #2287 but it actually has no effect. Executing the health check tests with go test -race ./... does not yield any difference. In both cases, it does not report any race.

timoreimann
timoreimann approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

LGTM.

@ldez ldez added this to the 1.6 milestone Jan 19, 2018
mmatur
mmatur approved these changes Jan 22, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez modified the milestones: 1.6, 1.5 Jan 22, 2018
@ldez ldez added kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. labels Jan 22, 2018
ldez
ldez approved these changes Jan 22, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c134dcd into traefik:master Jan 22, 2018
@ldez ldez modified the milestones: 1.5, 1.6 Jan 22, 2018
@ldez ldez changed the title remove unecessary mutex usage in healthchecks Remove unnecessary mutex usage in healthchecks Mar 23, 2018
@ldez ldez changed the title Remove unnecessary mutex usage in healthchecks Remove unnecessary mutex usage in health checks Mar 23, 2018
@MaxMood96 MaxMood96 mentioned this pull request May 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/healthcheck kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m3co-code @timoreimann @mmatur @ldez @traefiker