Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle undefined entrypoint on ACME config and frontend config #2756

Merged
merged 1 commit into from Jan 25, 2018
Merged

Handle undefined entrypoint on ACME config and frontend config #2756

merged 1 commit into from Jan 25, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 24, 2018 •
edited

What does this PR do?

Delete undefined entrypoints from frontent.entrypoints
Move Fatal if ACME.Entrypoint does not exists (from createTLSConfig to ValidateConfiguration)

Motivation

Handle some weird errors (like panic in postLoadConfiguration)

@traefiker traefiker added this to the 1.5 milestone Jan 24, 2018
nmengin
nmengin approved these changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏 👍

@juliens juliens force-pushed the undefined-entrypoint branch 2 times, most recently from 330e652 to 84a45da Compare January 25, 2018 09:29
ldez
ldez approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 323b823 into traefik:v1.5 Jan 25, 2018
@juliens juliens deleted the undefined-entrypoint branch January 25, 2018 20:12
@gozer gozer mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @mmatur @ldez @nmengin @traefiker