Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dnsrr endpoint mode excluded when not using swarm LB #2795

Merged
merged 1 commit into from Feb 5, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Feb 2, 2018

What does this PR do?

Fix an issue where Træfik stop exposing containers with endpoint_mode: dnsrr when label traefik.backend.loadbalancer.swarm=false

Motivation

Fixes #2793

More

  • Added/updated tests

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeifomin
Copy link

Looking forward 1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants