Display file log when test fails. #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
vdemeester
reviewed
Feb 5, 2018
There was a problem hiding this comment.
Given the fact that we use go-check, wouldn't it make more sense to do that in a TearDown or TearDownSuite method for the suite(s) ? It would remove some duplication and would help not forget to add it in new tests.
(if using testing instead of go-check, I think it would be best in TestMain 😛)
|
@vdemeester I already tested that:
Edit: this concern only the console output but it's not a problem for the log file |
mmatur
requested changes
Feb 5, 2018
integration/integration_test.go
Outdated
| @@ -19,8 +19,8 @@ import ( | |||
| checker "github.com/vdemeester/shakers" | |||
| ) | |||
|
|
|||
| var integration = flag.Bool("integration", false, "run integration tests") | |||
| var container = flag.Bool("container", false, "run container integration tests") | |||
| var integration = flag.Bool("integration", true, "run integration tests") | |||
integration/integration_test.go
Outdated
| var integration = flag.Bool("integration", false, "run integration tests") | ||
| var container = flag.Bool("container", false, "run container integration tests") | ||
| var integration = flag.Bool("integration", true, "run integration tests") | ||
| var container = flag.Bool("container", true, "run container integration tests") |
ldez
force-pushed
the
refactor/access-log
branch
from
7367c18
to
ecf5caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Display file log when test fails.
Clean some test methods.
Motivation
Have more information when tests fails.
More