Add multiple rules #285
Merged
Add multiple rules #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
add-multiple-rules
branch
from
99b490a
to
8486766
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
add-multiple-rules
branch
from
33d84dc
to
85fcff4
Compare
|
LGTM 🐷 |
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/1-needs-design-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple rules support.
You can now write your rules:
Host: foo.domain.com, bar.domain.comPath: /foo, /barPathStrip: /foo, /barAnd it also works with
PathPrefixandPathPrefixStrip.⚠
Hostrule no longer accepts regexp. Use the newHostRegexpinstead.⚠
Methodsrule is renamed toMethodFixes #179
Fixes #116
Signed-off-by: Emile Vauge emile@vauge.com