Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite entry point redirection. #2929

Merged
merged 1 commit into from Feb 26, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 25, 2018

What does this PR do?

Prevent the creation of a redirection on the same entry point.

Motivation

Fixes #2925

Additional Notes

With those labels:

traefik.frontend.entryPoints=http,https
traefik.frontend.redirect.entryPoint=https

The current behavior;

http://foo:80 -> https://foo:433 -> https://foo -> https://foo:443 -> https://foo -> ...

Due to:

Creating frontend frontend-PathPrefix-foo-0  
Wiring frontend frontend-PathPrefix-foo-0 to entryPoint http 
Creating route route-frontend-PathPrefix-foo-0 PathPrefix:/foo 
Creating entry point redirect http -> https   # <-----------------------------------
Frontend frontend-PathPrefix-foo-0 redirect created 
Creating backend backend-whoami1             
Creating load-balancer wrr                   
Creating server server-upbeat_goldberg at http://172.17.0.2:80 with weight 0 
Wiring frontend frontend-PathPrefix-foo-0 to entryPoint https 
Creating route route-frontend-PathPrefix-foo-0 PathPrefix:/foo 
Creating entry point redirect https -> https   # <----------------------------------- 
Frontend frontend-PathPrefix-foo-0 redirect created 

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple + Elegant
LGTM
:shipit:

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants