Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for lifecycle #2934

Merged
merged 1 commit into from Feb 27, 2018
Merged

Default value for lifecycle #2934

merged 1 commit into from Feb 27, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Feb 26, 2018

What does this PR do?

Fix the life cycle default value

Motivation

Fix a bug with no default value on Lifecycle and his child (GracefulTimeout)

More

Lifecycle is a pointer and the default value in the NewTraefikPointerConfiguration is not enough.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants